Removes support for jdbcURL prefix of jdbc:tc:shardingsphere0clickhouse:#33707
Merged
terrymanu merged 1 commit intoapache:masterfrom Nov 18, 2024
Merged
Removes support for jdbcURL prefix of jdbc:tc:shardingsphere0clickhouse:#33707terrymanu merged 1 commit intoapache:masterfrom
jdbc:tc:shardingsphere0clickhouse:#33707terrymanu merged 1 commit intoapache:masterfrom
Conversation
b575220 to
d19fe05
Compare
d19fe05 to
9e2fd76
Compare
terrymanu
approved these changes
Nov 18, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #29052.
Changes proposed in this pull request:
jdbc:tc:shardingsphere0clickhouse:. Due to the ongoing disputes at [Enhancement]:org.testcontainers.containers.ClickHouseProvidershould useclickhouse/clickhouse-serveras Docker Image testcontainers/testcontainers-java#8736 and Usesclickhouse/clickhouse-serveras Docker Image in ClickHouseProvider testcontainers/testcontainers-java#8738, it is not reasonable to continue to open holes on the side of shardingsphere.jdk11-22tojdk11+. This is a missed fix for Avoid using-proc:fullwhen compiling ShardingSphere with OpenJDK23 #33681.com.clickhouse:clickhouse-jdbc:0.6.3.Gy-MMis not a valid Japanese calendar format. I personally have little experience with the Japanese calendar and implementing support for it is very difficult.org.apache.shardingsphere:shardingsphere-infra-database-testcontainersoptional module.Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.